Skip to content
Snippets Groups Projects
Commit f18bea92 authored by Mayo Roettger's avatar Mayo Roettger
Browse files

corrections for CRAN, where && or || encountered arguments of length > 1

parent 418ac46f
No related branches found
No related tags found
No related merge requests found
Package: sybil
Type: Package
Title: Efficient Constrained Based Modelling
Version: 2.1.3
Date: 2019-02-21
Version: 2.1.4
Date: 2019-02-25
Authors@R: c(
person("Mayo", "Roettger", role = c("cre"), email = "mayo.roettger@hhu.de"),
person("Gabriel", "Gelius-Dietrich", role = "aut"),
......@@ -56,7 +56,7 @@ Collate: generics.R validmodelorg.R validoptsol.R validreactId.R validreact.R
sysBiolAlg_mtfClass.R sysBiolAlg_mtfEasyConstraintClass.R
sysBiolAlg_roomClass.R sybilLogClass.R upgradeModelorg.R
mergeReact2Modelorg.R
Packaged: 2019-02-21 16:35:00 UTC; mayo
Packaged: 2019-02-25 13:55:00 UTC; mayo
Author: Mayo Roettger [cre],
Gabriel Gelius-Dietrich [aut],
C. Jonathan Fritzemeier [ctb],
......
......@@ -42,8 +42,9 @@ addExchReact <- function(model, met, lb, ub) {
stop("needs an object of class modelorg")
}
if ( (length(met) < 1) || (met == "") ) {
stop("at least one metabolite is required")
#if ( (length(met) < 1) || (met == "") ) {
if ( (length(met) < 1) || (any(met == "")) ) {
stop("at least one metabolite is required and all metabolite character strings required to be non-empty")
}
if (missing(lb)) {
......
......@@ -7,6 +7,15 @@
\newcommand{\CRANpkg}{\href{https://CRAN.R-project.org/package=#1}{\pkg{#1}}}
% ---------------------------------------------------------------------------- %
\section{Changes in version 2.1.4 2019-02-25}{
\itemize{
\item Minor code change in \code{addExchReact} for CRAN submission, where
logical operator || encountered and used argument of length more than one.
\
}
}
% ---------------------------------------------------------------------------- %
\section{Changes in version 2.1.3 2018-12-21}{
\itemize{
\item Minor bug fix for function \code{getRedCosts} in \code{optObj_cplexAPI}.
......@@ -17,7 +26,7 @@
\section{Changes in version 2.1.2 2018-07-20}{
\itemize{
\item Maintainer change to Mayo Roettger <mayo.roettger@hhu.de>
\item Maintainer change to Mayo Roettger <mayo.roettger@hhu.de>.
\
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment