diff --git a/DESCRIPTION b/DESCRIPTION index 5d991b2aa4de63255e219438b2177a0fe5bf2e7f..d6d9aa7fb6097d9af78a545f5483037e7dc9473d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: sybil Type: Package Title: Efficient Constrained Based Modelling -Version: 2.1.3 -Date: 2019-02-21 +Version: 2.1.4 +Date: 2019-02-25 Authors@R: c( person("Mayo", "Roettger", role = c("cre"), email = "mayo.roettger@hhu.de"), person("Gabriel", "Gelius-Dietrich", role = "aut"), @@ -56,7 +56,7 @@ Collate: generics.R validmodelorg.R validoptsol.R validreactId.R validreact.R sysBiolAlg_mtfClass.R sysBiolAlg_mtfEasyConstraintClass.R sysBiolAlg_roomClass.R sybilLogClass.R upgradeModelorg.R mergeReact2Modelorg.R -Packaged: 2019-02-21 16:35:00 UTC; mayo +Packaged: 2019-02-25 13:55:00 UTC; mayo Author: Mayo Roettger [cre], Gabriel Gelius-Dietrich [aut], C. Jonathan Fritzemeier [ctb], diff --git a/R/addExchReact.R b/R/addExchReact.R index b459ef683603a661f9433d957ec3a322575e1e3f..d5b7acc3a9a6e8f82dd0a9e47d68126dc1562b74 100644 --- a/R/addExchReact.R +++ b/R/addExchReact.R @@ -42,8 +42,9 @@ addExchReact <- function(model, met, lb, ub) { stop("needs an object of class modelorg") } - if ( (length(met) < 1) || (met == "") ) { - stop("at least one metabolite is required") + #if ( (length(met) < 1) || (met == "") ) { + if ( (length(met) < 1) || (any(met == "")) ) { + stop("at least one metabolite is required and all metabolite character strings required to be non-empty") } if (missing(lb)) { diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd index 0f4f3d20507e82eb3a7d08b25c824aa254cdd79c..f602705f000d80108336d6214c6ce81087ba9393 100644 --- a/inst/NEWS.Rd +++ b/inst/NEWS.Rd @@ -7,6 +7,15 @@ \newcommand{\CRANpkg}{\href{https://CRAN.R-project.org/package=#1}{\pkg{#1}}} % ---------------------------------------------------------------------------- % +\section{Changes in version 2.1.4 2019-02-25}{ + \itemize{ + \item Minor code change in \code{addExchReact} for CRAN submission, where + logical operator || encountered and used argument of length more than one. + \ + } +} +% ---------------------------------------------------------------------------- % + \section{Changes in version 2.1.3 2018-12-21}{ \itemize{ \item Minor bug fix for function \code{getRedCosts} in \code{optObj_cplexAPI}. @@ -17,7 +26,7 @@ \section{Changes in version 2.1.2 2018-07-20}{ \itemize{ - \item Maintainer change to Mayo Roettger <mayo.roettger@hhu.de> + \item Maintainer change to Mayo Roettger <mayo.roettger@hhu.de>. \ } }