Skip to content
Snippets Groups Projects
Commit 2858972d authored by Claus Jonathan Fritzemeier's avatar Claus Jonathan Fritzemeier
Browse files

bug in addreact with modelorg_irrev

parent 17091871
Branches
No related tags found
No related merge requests found
Package: sybil Package: sybil
Type: Package Type: Package
Title: Efficient Constrained Based Modelling in R Title: Efficient Constrained Based Modelling in R
Version: 1.3.2 Version: 1.3.3
Date: 2015-11-16 Date: 2015-11-16
Authors@R: c( Authors@R: c(
person(c("C.", "Jonathan"), "Fritzemeier", role = c("cre", "ctb"), email = "clausjonathan.fritzemeier@uni-duesseldorf.de"), person(c("C.", "Jonathan"), "Fritzemeier", role = c("cre", "ctb"), email = "clausjonathan.fritzemeier@uni-duesseldorf.de"),
......
...@@ -317,7 +317,7 @@ addReact <- function(model, ...@@ -317,7 +317,7 @@ addReact <- function(model,
if (is(model, "modelorg_irrev")) { if (is(model, "modelorg_irrev")) {
mod_out <- modelorg_irrev(mod_id(model), mod_name(model)) mod_out <- modelorg_irrev(mod_id(model), mod_name(model))
irrev(mod_out) <- TRUE irrev(mod_out) <- TRUE
matchrev(mod_out) <- append(matchrev(model), 0) matchrev(mod_out) <- append(matchrev(model), 0L)
revReactId <- max(irrev2rev(model))+1 revReactId <- max(irrev2rev(model))+1
irrev2rev(mod_out) <- append(irrev2rev(model), revReactId) irrev2rev(mod_out) <- append(irrev2rev(model), revReactId)
......
...@@ -6,6 +6,12 @@ ...@@ -6,6 +6,12 @@
\newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}} \newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}}
\section{Changes in version 1.3.3 2015-11-25}{
\itemize{
\item \code{addReact} crashed for irreversible models.
}
}
% ---------------------------------------------------------------------------- %
\section{Changes in version 1.3.2 2015-10-21}{ \section{Changes in version 1.3.2 2015-10-21}{
\itemize{ \itemize{
\item New Algorithm \code{fbaEasyConstraint} and \code{mtfEasyConstraint} \item New Algorithm \code{fbaEasyConstraint} and \code{mtfEasyConstraint}
...@@ -14,6 +20,7 @@ ...@@ -14,6 +20,7 @@
\item \code{switch} needs the first parameter explicitly named. \item \code{switch} needs the first parameter explicitly named.
} }
} }
% ---------------------------------------------------------------------------- %
\section{Changes in version 1.3.1 2015-10-02}{ \section{Changes in version 1.3.1 2015-10-02}{
\itemize{ \itemize{
...@@ -21,6 +28,7 @@ ...@@ -21,6 +28,7 @@
\item \code{deadEndMetabolite()} could miss deadEndMetabolites if reactions differ in stoichiometry e.g. 1 and 2. \item \code{deadEndMetabolite()} could miss deadEndMetabolites if reactions differ in stoichiometry e.g. 1 and 2.
} }
} }
% ---------------------------------------------------------------------------- %
\section{Changes in version 1.3.1 2015-08-06}{ \section{Changes in version 1.3.1 2015-08-06}{
\itemize{ \itemize{
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment