From 2858972d6d5cc42f67bd14db8a8b7190dad5ddbf Mon Sep 17 00:00:00 2001 From: Claus Jonathan Fritzemeier <clausjonathan.fritzemeier@hhu.de> Date: Wed, 25 Nov 2015 10:48:34 +0100 Subject: [PATCH] bug in addreact with modelorg_irrev --- DESCRIPTION | 2 +- R/addReact.R | 2 +- inst/NEWS.Rd | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index c138f32..2cb2cd9 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: sybil Type: Package Title: Efficient Constrained Based Modelling in R -Version: 1.3.2 +Version: 1.3.3 Date: 2015-11-16 Authors@R: c( person(c("C.", "Jonathan"), "Fritzemeier", role = c("cre", "ctb"), email = "clausjonathan.fritzemeier@uni-duesseldorf.de"), diff --git a/R/addReact.R b/R/addReact.R index 1705cba..b7fe5c2 100644 --- a/R/addReact.R +++ b/R/addReact.R @@ -317,7 +317,7 @@ addReact <- function(model, if (is(model, "modelorg_irrev")) { mod_out <- modelorg_irrev(mod_id(model), mod_name(model)) irrev(mod_out) <- TRUE - matchrev(mod_out) <- append(matchrev(model), 0) + matchrev(mod_out) <- append(matchrev(model), 0L) revReactId <- max(irrev2rev(model))+1 irrev2rev(mod_out) <- append(irrev2rev(model), revReactId) diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd index 82b09df..2875c43 100644 --- a/inst/NEWS.Rd +++ b/inst/NEWS.Rd @@ -6,6 +6,12 @@ \newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}} +\section{Changes in version 1.3.3 2015-11-25}{ + \itemize{ + \item \code{addReact} crashed for irreversible models. + } +} +% ---------------------------------------------------------------------------- % \section{Changes in version 1.3.2 2015-10-21}{ \itemize{ \item New Algorithm \code{fbaEasyConstraint} and \code{mtfEasyConstraint} @@ -14,6 +20,7 @@ \item \code{switch} needs the first parameter explicitly named. } } +% ---------------------------------------------------------------------------- % \section{Changes in version 1.3.1 2015-10-02}{ \itemize{ @@ -21,6 +28,7 @@ \item \code{deadEndMetabolite()} could miss deadEndMetabolites if reactions differ in stoichiometry e.g. 1 and 2. } } +% ---------------------------------------------------------------------------- % \section{Changes in version 1.3.1 2015-08-06}{ \itemize{ -- GitLab