Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
Troubled Cell Detection
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Laura Christine Kühle
Troubled Cell Detection
Commits
d5e96473
Commit
d5e96473
authored
Oct 13, 2020
by
Laura Christine Kühle
Browse files
Options
Downloads
Patches
Plain Diff
Removed completed TODOs.
parent
f5efa2ef
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
DG_Approximation.py
+1
-13
1 addition, 13 deletions
DG_Approximation.py
with
1 addition
and
13 deletions
DG_Approximation.py
+
1
−
13
View file @
d5e96473
...
...
@@ -7,28 +7,16 @@ TODO: Contemplate using Seaborn instead of matplotlib
TODO: Double-check everything!
TODO: Replace loops with list comprehension if feasible
TODO: Combine initial projection and approx solution somehow
-> Done (decided against it because they are in different files now)
TODO: Investigate why there are no weights in approx calc -> Ask
TODO: Change order of methods -> Done
TODO: Change code to not include self. but global variables; NO, do private
\
or better protected instance variables instead -> Done (all protected)
TODO: Find better names for A, B, anything pertaining Gauss
TODO: Write documentation for all methods
TODO: Check whether consistency is given/possible for each class instance -> Done (should be okay when protected)
TODO: Contemplate moving A and B to Vectors_of_Polynomials
TODO: Improve access to names of classes -> Done (using self.__class__.__name__)
TODO: Improve use of self.__init__() -> Done
TODO: Check plots for NoDetection class -> Done (Adjusted scale of x-axis for shock tube)
TODO: Ask about shock tubes (course mesh vs fine mesh)
TODO: Check instance variables in all files -> Done
TODO: Improve saving of plots
TODO: Extend color options
TODO: Implement type check for all kwargs and configs
TODO: Make sure that self.cfl_number is not changed -> Done
TODO: Contemplate having a dict with a params and just getting the necessary ones
TODO: Adjust line breaks, remove unnecessary comments and parameter -> Done
TODO: Contemplate having a dict with all params and just getting the necessary ones
"""
import
numpy
as
np
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment