Skip to content
Snippets Groups Projects
Commit ad0b2977 authored by Laura Christine Kühle's avatar Laura Christine Kühle
Browse files

Sorted TODOs.

parent 61c59d46
Branches
No related tags found
No related merge requests found
...@@ -16,19 +16,28 @@ TODO: Contemplate saving training data for each IC separately ...@@ -16,19 +16,28 @@ TODO: Contemplate saving training data for each IC separately
TODO: Contemplate removing TrainingDataGenerator class TODO: Contemplate removing TrainingDataGenerator class
TODO: Ask why no fine mesh is used for calculate_coarse_projection() TODO: Ask why no fine mesh is used for calculate_coarse_projection()
TODO: Contemplate keeping Theoretical threshold over all degrees (only p) TODO: Contemplate keeping Theoretical threshold over all degrees (only p)
TODO: Contemplate reasoning behind Adjusted-Outer-Fence method -> Done (same options as Boxplot)
TODO: Discuss whether Threshold detector is needed
TODO: Contemplate reasoning behind Adjusted-Outer-Fence method -> Done
TODO: Discuss why indexed_coeffs are largest absolute value instead of TODO: Discuss why indexed_coeffs are largest absolute value instead of
mean for Boxplot TC mean for Boxplot TC -> Done (give option)
TODO: Discuss why overlapping cells are only introduced for one adjacent TODO: Discuss why overlapping cells are only introduced for one adjacent
fold (right neighbour, except for last fold) fold (right neighbour, except for last fold) -> Done
TODO: Discuss whether quartiles do correspond to Thea's calculation TODO: Discuss whether quartiles do correspond to Thea's calculation
-> Done (do not, change)
TODO: Discuss that quartiles do not take overlapping cells into account TODO: Discuss that quartiles do not take overlapping cells into account
-> Done (change)
TODO: Contemplate using pre-implemented quartile functions -> Done (do)
TODO: Contemplate restricting number of overlapping cells to half of fold TODO: Contemplate restricting number of overlapping cells to half of fold
length length -> Done (Restrict to 1 for now)
TODO: Contemplate whether overlapping cells should be evaluated in
neighboring folds -> Done (no)
TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len
TODO: Contemplate combining get_cells() and _get_cells() -> Done (enforce)
TODO: Contemplate combining get_cells() and _get_cells() -> Done (do)
Urgent: Urgent:
TODO: Enforce mesh with 2^n cells
TODO: Change heaviside random to uniform(-100, 100) TODO: Change heaviside random to uniform(-100, 100)
TODO: Adjust Heaviside to have non-symmetric values (left- and right_value) TODO: Adjust Heaviside to have non-symmetric values (left- and right_value)
TODO: Rename 'adjustment' to 'shift' TODO: Rename 'adjustment' to 'shift'
...@@ -76,6 +85,7 @@ Not feasible yet or doc-related: ...@@ -76,6 +85,7 @@ Not feasible yet or doc-related:
TODO: Use cfl_number for updating, not just time (equation-related?) TODO: Use cfl_number for updating, not just time (equation-related?)
TODO: Adjust code to allow classes for all equations TODO: Adjust code to allow classes for all equations
(Burger, linear advection, 1D Euler) (Burger, linear advection, 1D Euler)
TODO: Add ThresholdDetector
TODO: Double-check everything! (also with pylint, pytype, pydoc, TODO: Double-check everything! (also with pylint, pytype, pydoc,
pycodestyle, pydocstyle) pycodestyle, pydocstyle)
TODO: Check whether documentation style is correct TODO: Check whether documentation style is correct
......
...@@ -6,9 +6,13 @@ TODO: Vectorize _get_cells() in Boxplot method -> Done ...@@ -6,9 +6,13 @@ TODO: Vectorize _get_cells() in Boxplot method -> Done
TODO: Restructure Boxplot method -> Done TODO: Restructure Boxplot method -> Done
TODO: Introduce lower/upper extreme outliers in Boxplot TODO: Introduce lower/upper extreme outliers in Boxplot
(each cell is also checked for neighboring domains if existing) -> Done (each cell is also checked for neighboring domains if existing) -> Done
TODO: Give option to choose from multiwavelet degrees (first, last or
highest magnitude)
TODO: Change method of calculating quartiles
TODO: Include overlapping cells in quartile calculation (if needed)
TODO: Determine max_value for Theoretical only over highest degree TODO: Determine max_value for Theoretical only over highest degree
TODO: Check if indexing in wavelets is correct TODO: Check if indexing in wavelets is correct
TODO: Add ThresholdDetector TODO: Combine get_cells() and _get_cells()
TODO: Add TC condition to only flag cell if left-adjacent one is flagged as TODO: Add TC condition to only flag cell if left-adjacent one is flagged as
well (remove this condition) well (remove this condition)
TODO: Check coarse_projection calculation for indexing errors TODO: Check coarse_projection calculation for indexing errors
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment