Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
Troubled Cell Detection
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Laura Christine Kühle
Troubled Cell Detection
Commits
ad0b2977
Commit
ad0b2977
authored
2 years ago
by
Laura Christine Kühle
Browse files
Options
Downloads
Patches
Plain Diff
Sorted TODOs.
parent
61c59d46
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
DG_Approximation.py
+15
-5
15 additions, 5 deletions
DG_Approximation.py
Troubled_Cell_Detector.py
+5
-1
5 additions, 1 deletion
Troubled_Cell_Detector.py
with
20 additions
and
6 deletions
DG_Approximation.py
+
15
−
5
View file @
ad0b2977
...
@@ -16,19 +16,28 @@ TODO: Contemplate saving training data for each IC separately
...
@@ -16,19 +16,28 @@ TODO: Contemplate saving training data for each IC separately
TODO: Contemplate removing TrainingDataGenerator class
TODO: Contemplate removing TrainingDataGenerator class
TODO: Ask why no fine mesh is used for calculate_coarse_projection()
TODO: Ask why no fine mesh is used for calculate_coarse_projection()
TODO: Contemplate keeping Theoretical threshold over all degrees (only p)
TODO: Contemplate keeping Theoretical threshold over all degrees (only p)
TODO: Contemplate reasoning behind Adjusted-Outer-Fence method
-> Done (same options as Boxplot)
TODO: Discuss whether Threshold detector is needed
TODO: Contemplate reasoning behind Adjusted-Outer-Fence method -> Done
TODO: Discuss why indexed_coeffs are largest absolute value instead of
TODO: Discuss why indexed_coeffs are largest absolute value instead of
mean for Boxplot TC
mean for Boxplot TC
-> Done (give option)
TODO: Discuss why overlapping cells are only introduced for one adjacent
TODO: Discuss why overlapping cells are only introduced for one adjacent
fold (right neighbour, except for last fold)
fold (right neighbour, except for last fold)
-> Done
TODO: Discuss whether quartiles do correspond to Thea
'
s calculation
TODO: Discuss whether quartiles do correspond to Thea
'
s calculation
-> Done (do not, change)
TODO: Discuss that quartiles do not take overlapping cells into account
TODO: Discuss that quartiles do not take overlapping cells into account
-> Done (change)
TODO: Contemplate using pre-implemented quartile functions -> Done (do)
TODO: Contemplate restricting number of overlapping cells to half of fold
TODO: Contemplate restricting number of overlapping cells to half of fold
length
length -> Done (Restrict to 1 for now)
TODO: Contemplate whether overlapping cells should be evaluated in
neighboring folds -> Done (no)
TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len
TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len
TODO: Contemplate combining get_cells() and _get_cells()
-> Done (enforce)
TODO: Contemplate combining get_cells() and _get_cells() -> Done (do)
Urgent:
Urgent:
TODO: Enforce mesh with 2^n cells
TODO: Change heaviside random to uniform(-100, 100)
TODO: Change heaviside random to uniform(-100, 100)
TODO: Adjust Heaviside to have non-symmetric values (left- and right_value)
TODO: Adjust Heaviside to have non-symmetric values (left- and right_value)
TODO: Rename
'
adjustment
'
to
'
shift
'
TODO: Rename
'
adjustment
'
to
'
shift
'
...
@@ -76,6 +85,7 @@ Not feasible yet or doc-related:
...
@@ -76,6 +85,7 @@ Not feasible yet or doc-related:
TODO: Use cfl_number for updating, not just time (equation-related?)
TODO: Use cfl_number for updating, not just time (equation-related?)
TODO: Adjust code to allow classes for all equations
TODO: Adjust code to allow classes for all equations
(Burger, linear advection, 1D Euler)
(Burger, linear advection, 1D Euler)
TODO: Add ThresholdDetector
TODO: Double-check everything! (also with pylint, pytype, pydoc,
TODO: Double-check everything! (also with pylint, pytype, pydoc,
pycodestyle, pydocstyle)
pycodestyle, pydocstyle)
TODO: Check whether documentation style is correct
TODO: Check whether documentation style is correct
...
...
This diff is collapsed.
Click to expand it.
Troubled_Cell_Detector.py
+
5
−
1
View file @
ad0b2977
...
@@ -6,9 +6,13 @@ TODO: Vectorize _get_cells() in Boxplot method -> Done
...
@@ -6,9 +6,13 @@ TODO: Vectorize _get_cells() in Boxplot method -> Done
TODO: Restructure Boxplot method -> Done
TODO: Restructure Boxplot method -> Done
TODO: Introduce lower/upper extreme outliers in Boxplot
TODO: Introduce lower/upper extreme outliers in Boxplot
(each cell is also checked for neighboring domains if existing) -> Done
(each cell is also checked for neighboring domains if existing) -> Done
TODO: Give option to choose from multiwavelet degrees (first, last or
highest magnitude)
TODO: Change method of calculating quartiles
TODO: Include overlapping cells in quartile calculation (if needed)
TODO: Determine max_value for Theoretical only over highest degree
TODO: Determine max_value for Theoretical only over highest degree
TODO: Check if indexing in wavelets is correct
TODO: Check if indexing in wavelets is correct
TODO:
Add ThresholdDetector
TODO:
Combine get_cells() and _get_cells()
TODO: Add TC condition to only flag cell if left-adjacent one is flagged as
TODO: Add TC condition to only flag cell if left-adjacent one is flagged as
well (remove this condition)
well (remove this condition)
TODO: Check coarse_projection calculation for indexing errors
TODO: Check coarse_projection calculation for indexing errors
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment