Skip to content
Snippets Groups Projects
Commit 2745cb74 authored by Laura Christine Kühle's avatar Laura Christine Kühle
Browse files

Sorted TODOs.

parent 38895885
No related branches found
No related tags found
No related merge requests found
...@@ -14,6 +14,7 @@ TODO: Contemplate containing boundary condition in Mesh ...@@ -14,6 +14,7 @@ TODO: Contemplate containing boundary condition in Mesh
TODO: Ask whether all quadratures depend on freely chosen num_nodes TODO: Ask whether all quadratures depend on freely chosen num_nodes
TODO: Contemplate saving training data for each IC separately TODO: Contemplate saving training data for each IC separately
TODO: Contemplate removing TrainingDataGenerator class TODO: Contemplate removing TrainingDataGenerator class
TODO: Ask why no fine mesh is used for calculate_coarse_projection()
Urgent: Urgent:
TODO: Investigate self-referencing in classes -> Done TODO: Investigate self-referencing in classes -> Done
...@@ -22,45 +23,44 @@ TODO: Refactor random_stencil() -> Done ...@@ -22,45 +23,44 @@ TODO: Refactor random_stencil() -> Done
TODO: Fix bug applying wrong boundary condition when generating ANN TODO: Fix bug applying wrong boundary condition when generating ANN
training data -> Done training data -> Done
TODO: Find errors in centering for ANN training -> Done TODO: Find errors in centering for ANN training -> Done
TODO: Remove stencil_length as instance variable TODO: Remove stencil_length as instance variable -> Done
TODO: Note down TCD adjustment TODOs -> Done
TODO: Adapt TCD from Soraya TODO: Adapt TCD from Soraya
(Dropbox->...->TEST_troubled-cell-detector->Troubled_Cell_Detector) (Dropbox->...->TEST_troubled-cell-detector->Troubled_Cell_Detector)
TODO: Add TC condition to only flag cell if left-adjacent one is flagged as
well
TODO: Move plot_approximation_results() into plotting script TODO: Move plot_approximation_results() into plotting script
TODO: Add verbose output
TODO: Improve file naming (e.g. use '.' instead of '__') TODO: Improve file naming (e.g. use '.' instead of '__')
TODO: Check whether ghost cells are handled/set correctly TODO: Check whether ghost cells are handled/set correctly
TODO: Unify use of 'length' and 'len' in naming TODO: Unify use of 'length' and 'len' in naming
TODO: Unify use of 'initial_condition' and 'init_cond' in naming TODO: Unify use of 'initial_condition' and 'init_cond' in naming
TODO: Ensure uniform use of mesh and grid TODO: Unify use of 'mesh' and 'grid' in naming
TODO: Check sign change in stiffness matrix to accommodate negative wave speed
TODO: Check whether 'projection' is always a ndarray
TODO: Force input_size for each ANN model to be stencil length
Critical, but not urgent: Critical, but not urgent:
TODO: Combine ANN workflows TODO: Add verbose output
TODO: Build package (module?) for DG scheme TODO: Outsource scripts into separate directory
TODO: Add an environment file for Snakemake TODO: Check whether all instance variables are sensible
TODO: Combine ANN workflows if feasible
TODO: Investigate profiling for speed up TODO: Investigate profiling for speed up
TODO: Rework Theoretical TC for efficiency TODO: Rework Theoretical TC for efficiency
TODO: Check sign change in stiffness matrix to accommodate negative wave speed
TODO: Investigate g-mesh(?)
TODO: Create g-mesh with Mesh class
TODO: Force input_size for each ANN model to be stencil length
TODO: Use full path for ANN model state
TODO: Extract object initialization from DGScheme TODO: Extract object initialization from DGScheme
TODO: Use cfl_number for updating, not just time
Currently not critical:
TODO: Replace loops with list comprehension if feasible TODO: Replace loops with list comprehension if feasible
TODO: Replace loops/list comprehension with vectorization if feasible TODO: Replace loops/list comprehension with vectorization if feasible
TODO: Check whether 'projection' is always a ndarray
TODO: Check whether all instance variables are sensible Currently not critical:
TODO: Add an environment file for Snakemake
TODO: Build package (module?) for DG scheme
TODO: Investigate g-mesh(?)
TODO: Create g-mesh with Mesh class
TODO: Rename files according to standard TODO: Rename files according to standard
TODO: Outsource scripts into separate directory
TODO: Allow comparison between ANN training datasets TODO: Allow comparison between ANN training datasets
TODO: Use full path for ANN model state
TODO: Add a default model state TODO: Add a default model state
TODO: Look into validators for variable checks TODO: Look into validators for variable checks
Not feasible yet or doc-related: Not feasible yet or doc-related:
TODO: Use cfl_number for updating, not just time (equation-related?)
TODO: Adjust code to allow classes for all equations TODO: Adjust code to allow classes for all equations
(Burger, linear advection, 1D Euler) (Burger, linear advection, 1D Euler)
TODO: Double-check everything! (also with pylint, pytype, pydoc, TODO: Double-check everything! (also with pylint, pytype, pydoc,
......
...@@ -2,6 +2,12 @@ ...@@ -2,6 +2,12 @@
""" """
@author: Laura C. Kühle, Soraya Terrab (sorayaterrab) @author: Laura C. Kühle, Soraya Terrab (sorayaterrab)
TODO: Add TC condition to only flag cell if left-adjacent one is flagged as
well
TODO: Determine max_value for Theoretical only over 0th degree (?)
TODO: Introduce Adjusted Outer Fence method in Boxplot using global_mean
TODO: Introduce overlapping cell for adjacent folds in Boxplot
TODO: Introduce lower extreme outliers in Boxplot
TODO: Adjust TCs for wavelet detectors (sliding window over all cells instead TODO: Adjust TCs for wavelet detectors (sliding window over all cells instead
of every second) of every second)
TODO: Adjust Boxplot approach (adjacent cells, outer fence, etc.) TODO: Adjust Boxplot approach (adjacent cells, outer fence, etc.)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment