-
- Downloads
Replace kernel parameter of Command methods with injection
ProBKernel is now a singleton (it's very unlikely that we'll ever need to run multiple kernels in a single process, and if we do, each would have its own injector anyway). This allows injecting it into commands when they need it. This makes more sense than using a parameter, because most commands don't need access to the kernel object. We have to use an Injector and inject the kernel only when it's actually used. We can't inject the kernel as a constructor parameter, because the ProBKernel constructor injects all the commands, which would cause a circular dependency.
Showing
- src/main/java/de/prob2/jupyter/ProBKernel.java 6 additions, 4 deletionssrc/main/java/de/prob2/jupyter/ProBKernel.java
- src/main/java/de/prob2/jupyter/commands/AssertCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/AssertCommand.java
- src/main/java/de/prob2/jupyter/commands/BrowseCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/BrowseCommand.java
- src/main/java/de/prob2/jupyter/commands/Command.java 2 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/Command.java
- src/main/java/de/prob2/jupyter/commands/ConstantsCommand.java 2 additions, 3 deletions...main/java/de/prob2/jupyter/commands/ConstantsCommand.java
- src/main/java/de/prob2/jupyter/commands/DotCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/DotCommand.java
- src/main/java/de/prob2/jupyter/commands/EvalCommand.java 2 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/EvalCommand.java
- src/main/java/de/prob2/jupyter/commands/ExecCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/ExecCommand.java
- src/main/java/de/prob2/jupyter/commands/GroovyCommand.java 7 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/GroovyCommand.java
- src/main/java/de/prob2/jupyter/commands/HelpCommand.java 16 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/HelpCommand.java
- src/main/java/de/prob2/jupyter/commands/InitialiseCommand.java 2 additions, 3 deletions...ain/java/de/prob2/jupyter/commands/InitialiseCommand.java
- src/main/java/de/prob2/jupyter/commands/LoadCellCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/LoadCellCommand.java
- src/main/java/de/prob2/jupyter/commands/LoadFileCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/LoadFileCommand.java
- src/main/java/de/prob2/jupyter/commands/PrefCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/PrefCommand.java
- src/main/java/de/prob2/jupyter/commands/PrettyPrintCommand.java 2 additions, 4 deletions...in/java/de/prob2/jupyter/commands/PrettyPrintCommand.java
- src/main/java/de/prob2/jupyter/commands/RenderCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/RenderCommand.java
- src/main/java/de/prob2/jupyter/commands/ShowCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/ShowCommand.java
- src/main/java/de/prob2/jupyter/commands/SolveCommand.java 2 additions, 3 deletionssrc/main/java/de/prob2/jupyter/commands/SolveCommand.java
- src/main/java/de/prob2/jupyter/commands/TableCommand.java 2 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/TableCommand.java
- src/main/java/de/prob2/jupyter/commands/TimeCommand.java 10 additions, 4 deletionssrc/main/java/de/prob2/jupyter/commands/TimeCommand.java
Loading
Please register or sign in to comment