remove fail book in multiwoz goal generator

convlab2/policy/rule/multiwoz/policy_agenda_multiwoz.py

@@ -391,6 +391,7 @@ class Agenda(object):
             domain = goal.domains[idx]
 
             # inform
+            # first ask fail_info which return no result then ask info
             if 'fail_info' in goal.domain_goals[domain]:
                 for slot in random_sample(goal.domain_goals[domain]['fail_info'].keys(),
                                           len(goal.domain_goals[domain]['fail_info'])):
@@ -876,7 +877,9 @@ if __name__ == '__main__':
     user_policy.init_session()
     sys_policy.init_session()
 
-    print(user_policy.goal)
+    goal = user_policy.get_goal()
+
+    print(goal)
 
     print(user_policy.agenda)
     user_act = user_policy.predict([])
@@ -895,6 +898,9 @@ if __name__ == '__main__':
     print(user_act)
     user_utt = user_nlg.generate(user_act)
     print(user_utt)
+
+    print(goal)
+
     sys_act = sys_policy.predict(state)
     print(sys_act)
 

convlab2/task/multiwoz/goal_generator.py

@@ -422,27 +422,27 @@ class GoalGenerator:
                 if domain == 'train' and len(domain_goal['book']) <= 0:
                     domain_goal['book']['people'] = nomial_sample(cnt_slot_value['book']['people'])
 
-            # fail_book
-            if 'book' in domain_goal and random.random() < 0.5:
-                if domain == 'hotel':
-                    domain_goal['fail_book'] = deepcopy(domain_goal['book'])
-                    if 'stay' in domain_goal['book'] and random.random() < 0.5:
-                        # increase hotel-stay
-                        domain_goal['fail_book']['stay'] = str(int(domain_goal['book']['stay']) + 1)
-                    elif 'day' in domain_goal['book']:
-                        # push back hotel-day by a day
-                        domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) - 1) % 7]
-
-                elif domain == 'restaurant':
-                    domain_goal['fail_book'] = deepcopy(domain_goal['book'])
-                    if 'time' in domain_goal['book'] and random.random() < 0.5:
-                        hour, minute = domain_goal['book']['time'].split(':')
-                        domain_goal['fail_book']['time'] = str((int(hour) + 1) % 24) + ':' + minute
-                    elif 'day' in domain_goal['book']:
-                        if random.random() < 0.5:
-                            domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) - 1) % 7]
-                        else:
-                            domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) + 1) % 7]
+            # fail_book: not use any more since 2020.8.18
+            # if 'book' in domain_goal and random.random() < 0.5:
+            #     if domain == 'hotel':
+            #         domain_goal['fail_book'] = deepcopy(domain_goal['book'])
+            #         if 'stay' in domain_goal['book'] and random.random() < 0.5:
+            #             # increase hotel-stay
+            #             domain_goal['fail_book']['stay'] = str(int(domain_goal['book']['stay']) + 1)
+            #         elif 'day' in domain_goal['book']:
+            #             # push back hotel-day by a day
+            #             domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) - 1) % 7]
+            #
+            #     elif domain == 'restaurant':
+            #         domain_goal['fail_book'] = deepcopy(domain_goal['book'])
+            #         if 'time' in domain_goal['book'] and random.random() < 0.5:
+            #             hour, minute = domain_goal['book']['time'].split(':')
+            #             domain_goal['fail_book']['time'] = str((int(hour) + 1) % 24) + ':' + minute
+            #         elif 'day' in domain_goal['book']:
+            #             if random.random() < 0.5:
+            #                 domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) - 1) % 7]
+            #             else:
+            #                 domain_goal['fail_book']['day'] = days[(days.index(domain_goal['book']['day']) + 1) % 7]
 
             # fail_info
             if 'info' in domain_goal and len(self.db.query(domain, domain_goal['info'].items())) == 0:
@@ -453,6 +453,7 @@ class GoalGenerator:
                         if domain == 'train':
                             domain_goal['info'] = adjusted_info
                         else:
+                            # first ask fail_info which return no result then ask info
                             domain_goal['fail_info'] = domain_goal['info']
                             domain_goal['info'] = adjusted_info