From e7eed3c09e0ebfdb3615cc3cbdba9e73e62ed40b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=BChle=2C=20Laura=20Christine=20=28lakue103=29?= <laura.kuehle@uni-duesseldorf.de> Date: Fri, 12 May 2023 10:13:35 +0200 Subject: [PATCH] Removed completed TODOs. --- Snakefile | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/Snakefile b/Snakefile index 98234a3..207306e 100644 --- a/Snakefile +++ b/Snakefile @@ -22,24 +22,15 @@ TODO: Contemplate using lambdify for basis TODO: Contemplate allowing vector input for ICs TODO: Discuss how wavelet details should be plotted -TODO: Ask whether we are dealing with inviscid Burgers only -> Done (yes) -TODO: Ask why we limit the initial time step -> Done (to prevent - irregularities related to instability in later steps) -TODO: Ask whether cfl number should be absolute value -> Done (by definition) -TODO: Ask why cells 1 and -2 are adjusted for Dirichlet boundary -> Done ( - not sure, try with ghost cells only for now) -TODO: Ask why height adjustment and stretch factor are considered outside of - implicit solver function -> Done (can be in solver) -TODO: Ask about workings of implicit solver for Burgers - -> Done (look into file burgex.f) -TODO: Ask whether Burgers has compatible ICs other than Sine (shock case) and - DiscontinuousConstant (rarefaction) -> Done (yes, but irrelevant for now) -TODO: Ask about fluxes other than Lax Friedrich -> Done (not needed now) - Urgent: +TODO: Mark Burgers' equation as inviscid +TODO: Make sure CFL number is absolute value +TODO: Make sure only ghost cells are limited for Dirichlet boundary +TODO: Move height adjustment and stretch factor into implicit solver function +TODO: Check correctness of implicit solver (with burgex.f) TODO: Add Burgers class completely TODO: Enable choice of equation -TODO: Add subclasses of Burgers +TODO: Add subclasses of Burgers (rarefaction and shock case) TODO: Ignore ghost domains by flagging all cells with it for extreme outlier TODO: Add functions to create each object from dict TODO: Initialize boundary config properly -- GitLab