From 990f670ca9230e8e731c33470afcc0883d8bd506 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=BChle=2C=20Laura=20Christine=20=28lakue103=29?= <laura.kuehle@uni-duesseldorf.de> Date: Thu, 15 Sep 2022 14:40:29 +0200 Subject: [PATCH] Removed completed TODOs. --- DG_Approximation.py | 20 -------------------- Troubled_Cell_Detector.py | 4 ---- 2 files changed, 24 deletions(-) diff --git a/DG_Approximation.py b/DG_Approximation.py index 48ea3e5..bb8d8af 100644 --- a/DG_Approximation.py +++ b/DG_Approximation.py @@ -15,26 +15,6 @@ TODO: Ask whether all quadratures depend on freely chosen num_nodes TODO: Contemplate saving training data for each IC separately TODO: Contemplate removing TrainingDataGenerator class TODO: Ask why no fine mesh is used for calculate_coarse_projection() -TODO: Contemplate keeping Theoretical threshold over all degrees (only p) - -> Done (same options as Boxplot) -TODO: Discuss whether Threshold detector is needed -TODO: Contemplate reasoning behind Adjusted-Outer-Fence method -> Done -TODO: Discuss why indexed_coeffs are largest absolute value instead of - mean for Boxplot TC -> Done (give option) -TODO: Discuss why overlapping cells are only introduced for one adjacent - fold (right neighbour, except for last fold) -> Done -TODO: Discuss whether quartiles do correspond to Thea's calculation - -> Done (do not, change) -TODO: Discuss that quartiles do not take overlapping cells into account - -> Done (change) -TODO: Contemplate using pre-implemented quartile functions -> Done (do) -TODO: Contemplate restricting number of overlapping cells to half of fold - length -> Done (Restrict to 1 for now) -TODO: Contemplate whether overlapping cells should be evaluated in - neighboring folds -> Done (no) -TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len - -> Done (enforce) -TODO: Contemplate combining get_cells() and _get_cells() -> Done (do) Urgent: TODO: Enforce mesh with 2^n cells diff --git a/Troubled_Cell_Detector.py b/Troubled_Cell_Detector.py index 08df252..ce9de57 100644 --- a/Troubled_Cell_Detector.py +++ b/Troubled_Cell_Detector.py @@ -2,10 +2,6 @@ """ @author: Laura C. Kühle, Soraya Terrab (sorayaterrab) -TODO: Vectorize _get_cells() in Boxplot method -> Done -TODO: Restructure Boxplot method -> Done -TODO: Introduce lower/upper extreme outliers in Boxplot - (each cell is also checked for neighboring domains if existing) -> Done TODO: Give option to choose from multiwavelet degrees (first, last or highest magnitude) TODO: Change method of calculating quartiles -- GitLab