From 764d03e62247caa26fe5c223a1e8803128b16a6f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=BChle=2C=20Laura=20Christine=20=28lakue103=29?=
<laura.kuehle@uni-duesseldorf.de>
Date: Tue, 5 Apr 2022 12:14:57 +0200
Subject: [PATCH] Removed completed TODOs.
---
DG_Approximation.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/DG_Approximation.py b/DG_Approximation.py
index 9e1cb82..27ad5ec 100644
--- a/DG_Approximation.py
+++ b/DG_Approximation.py
@@ -3,10 +3,11 @@
@author: Laura C. Kühle
Discussion:
+TODO: Contemplate saving 5-CV split and evaluating models separately
+TODO: Contemplate separating cell average and reconstruction calculations
Urgent:
-TODO: Rename Vector to Basis
-TODO: Extract ndarray encoding and decoding -> Done
+TODO: Move calculate_cell_average() to Basis
TODO: Hard-code simplification of cell average/reconstruction in basis
TODO: Make basis variables public (if feasible)
TODO: Contain polynomial degree in basis
@@ -15,9 +16,7 @@ TODO: Introduce Mesh class
TODO: Check whether ghost cells are handled/set correctly
TODO: Find error in centering for ANN training
TODO: Investigate g-mesh(?)
-TODO: Contain all plotting in Plotting -> Done
TODO: Remove use of DGScheme from ANN_Data_Generator
-TODO: Clean up docstrings
TODO: Adapt TCD from Soraya
(Dropbox->...->TEST_troubled-cell-detector->Troubled_Cell_Detector)
TODO: Add verbose output
@@ -35,7 +34,7 @@ TODO: Use cfl_number for updating, not just time
Currently not critical:
TODO: Unify use of 'length' and 'len' in naming
TODO: Replace loops with list comprehension if feasible
-TODO: Check whether 'projection' is always a np.array()
+TODO: Check whether 'projection' is always a ndarray
TODO: Check whether all instance variables are sensible
TODO: Rename files according to standard
TODO: Outsource scripts into separate directory
@@ -52,6 +51,7 @@ TODO: Check whether documentation style is correct
TODO: Check whether all types in doc are correct
TODO: Discuss adding kwargs to attributes in documentation
TODO: Add type annotations to function heads
+TODO: Clean up docstrings
"""
import json
--
GitLab