From 2382f3b11e4c5765b7640ec0814a8eec6810554b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=BChle=2C=20Laura=20Christine=20=28lakue103=29?= <laura.kuehle@uni-duesseldorf.de> Date: Tue, 6 Sep 2022 11:56:55 +0200 Subject: [PATCH] Removed abstract decorator from 'randomize()' for initial conditions. --- DG_Approximation.py | 12 ++++++++++++ Initial_Condition.py | 1 - 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/DG_Approximation.py b/DG_Approximation.py index 8b4bad5..51b5f4e 100644 --- a/DG_Approximation.py +++ b/DG_Approximation.py @@ -16,8 +16,20 @@ TODO: Contemplate saving training data for each IC separately TODO: Contemplate removing TrainingDataGenerator class TODO: Ask why no fine mesh is used for calculate_coarse_projection() TODO: Contemplate keeping Theoretical threshold over all degrees (only p) +TODO: Contemplate reasoning behind Adjusted-Outer-Fence method +TODO: Discuss why indexed_coeffs are largest absolute value instead of + mean for Boxplot TC +TODO: Discuss why overlapping cells are only introduced for one adjacent + fold (right neighbour, except for last fold) +TODO: Discuss whether quartiles do correspond to Thea's calculation +TODO: Discuss that quartiles do not take overlapping cells into account +TODO: Contemplate restricting number of overlapping cells to half of fold + length +TODO: Discuss if folds are valid for all possible num_grid_cells/fold_len +TODO: Contemplate combining get_cells() and _get_cells() Urgent: +TODO: Remove abstract decorator from 'randomize()' for ICs -> Done TODO: Change heaviside random to uniform(-100, 100) TODO: Adjust Heaviside to have non-symmetric values (left- and right_value) TODO: Rename 'adjustment' to 'shift' diff --git a/Initial_Condition.py b/Initial_Condition.py index 3ce562a..a7dc0bb 100644 --- a/Initial_Condition.py +++ b/Initial_Condition.py @@ -65,7 +65,6 @@ class InitialCondition(ABC): """ pass - @abstractmethod def randomize(self, config): """Sets all non-determined instance variables to random value. -- GitLab