From 867ba81098453bdd35405ec6d9ddfea11553664d Mon Sep 17 00:00:00 2001 From: dgelessus <dgelessus@users.noreply.github.com> Date: Thu, 27 Apr 2023 17:20:59 +0200 Subject: [PATCH] Use standard assertEquals in TestUtil.compare This way it prints the actual strings it compares - previously it compared one pair of string, then printed a different pair on failure! The default failure message is sometimes not as nice, but it highlights the differences, and IDEs can show a better diff. If you need to see the full strings, you can add prints locally. --- src/test/java/de/tlc4b/util/TestUtil.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/test/java/de/tlc4b/util/TestUtil.java b/src/test/java/de/tlc4b/util/TestUtil.java index f6c9071..3d39315 100644 --- a/src/test/java/de/tlc4b/util/TestUtil.java +++ b/src/test/java/de/tlc4b/util/TestUtil.java @@ -21,7 +21,6 @@ import de.tlc4b.tlc.TLCResults.TLCResult; import util.ToolIO; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.fail; public class TestUtil { @@ -35,14 +34,9 @@ public class TestUtil { // TODO create standard modules BBuildins String moduleName = b2tlaTranslator.getMachineName(); - String str1 = de.tla2bAst.Translator.translateModuleString(moduleName, b2tlaTranslator.getModuleString(), null); - - String str2 = de.tla2bAst.Translator.translateModuleString(moduleName, expectedModule, null); - if (!str1.equals(str2)) { - // assertEquals(expected, actual); - - fail("expected:\n" + expectedModule + "\nbut was:\n" + b2tlaTranslator.getModuleString()); - } + String actualB = de.tla2bAst.Translator.translateModuleString(moduleName, b2tlaTranslator.getModuleString(), null); + String expectedB = de.tla2bAst.Translator.translateModuleString(moduleName, expectedModule, null); + assertEquals(expectedB, actualB); } public static void tryTranslating(final String machineString) throws BException { -- GitLab