From 64140e5940f5449833f0ed50f362f4c3b22579be Mon Sep 17 00:00:00 2001
From: loki der quaeler <quaeler@gmail.com>
Date: Sun, 15 Mar 2020 12:52:06 -0700
Subject: [PATCH] Spaces in the PDF file path were preventing PDF external open

. Letting the Runtime exec operation handle any potential spaces in the filepath.

[Bug][Toolbox]
---
 .../src/org/lamport/tla/toolbox/doc/handler/HelpPDFHandler.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.lamport.tla.toolbox.doc/src/org/lamport/tla/toolbox/doc/handler/HelpPDFHandler.java b/org.lamport.tla.toolbox.doc/src/org/lamport/tla/toolbox/doc/handler/HelpPDFHandler.java
index 3063bc9f3..659fb599b 100644
--- a/org.lamport.tla.toolbox.doc/src/org/lamport/tla/toolbox/doc/handler/HelpPDFHandler.java
+++ b/org.lamport.tla.toolbox.doc/src/org/lamport/tla/toolbox/doc/handler/HelpPDFHandler.java
@@ -67,7 +67,7 @@ public class HelpPDFHandler extends AbstractHandler implements IHandler {
 				try {
 					final File pdfFile = getDocFile("/pdfs/" + pdf);
 					if (osOpensPDF) {
-						final String openCommand = "open " + pdfFile.getAbsolutePath();
+						final String[] openCommand = { "open", pdfFile.getAbsolutePath() };
 						
 						Runtime.getRuntime().exec(openCommand);
 					} else if (useEmbeddedViewer) {
-- 
GitLab