From 68ad0a1820038bcc86a39581d6818f5cd335d77b Mon Sep 17 00:00:00 2001 From: dgelessus <dgelessus@users.noreply.github.com> Date: Fri, 10 Jan 2025 12:06:17 +0100 Subject: [PATCH] Remove final on local variables --- .../sablecc/gradle/DefaultSableCCSourceSet.java | 4 ++-- .../de/hhu/stups/sablecc/gradle/SableCCPlugin.java | 14 +++++++------- .../hhu/stups/sablecc/gradle/SableCCSourceSet.java | 2 +- .../de/hhu/stups/sablecc/gradle/SableCCTask.java | 12 ++++++------ 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/main/java/de/hhu/stups/sablecc/gradle/DefaultSableCCSourceSet.java b/src/main/java/de/hhu/stups/sablecc/gradle/DefaultSableCCSourceSet.java index 35fb5f6..a52c877 100644 --- a/src/main/java/de/hhu/stups/sablecc/gradle/DefaultSableCCSourceSet.java +++ b/src/main/java/de/hhu/stups/sablecc/gradle/DefaultSableCCSourceSet.java @@ -11,7 +11,7 @@ import org.gradle.api.reflect.TypeOf; final class DefaultSableCCSourceSet implements SableCCSourceSet, HasPublicType { private final SourceDirectorySet sableCC; - DefaultSableCCSourceSet(final String displayName, final ObjectFactory objectFactory) { + DefaultSableCCSourceSet(String displayName, ObjectFactory objectFactory) { super(); this.sableCC = objectFactory.sourceDirectorySet(NAME, displayName + " SableCC source"); @@ -25,7 +25,7 @@ final class DefaultSableCCSourceSet implements SableCCSourceSet, HasPublicType { } @Override - public SableCCSourceSet sableCC(final Action<? super SourceDirectorySet> configureAction) { + public SableCCSourceSet sableCC(Action<? super SourceDirectorySet> configureAction) { configureAction.execute(this.getSableCC()); return this; } diff --git a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCPlugin.java b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCPlugin.java index d009f1c..633c8d7 100644 --- a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCPlugin.java +++ b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCPlugin.java @@ -22,7 +22,7 @@ public class SableCCPlugin implements Plugin<Project> { } @Override - public void apply(final Project project) { + public void apply(Project project) { project.getPluginManager().apply(JavaPlugin.class); // Create the sableCC configuration (used to specify which SableCC version to use). @@ -37,21 +37,21 @@ public class SableCCPlugin implements Plugin<Project> { project.getExtensions().getByType(JavaPluginExtension.class).getSourceSets().all(sourceSet -> { // Create the sablecc source directory set. - final String sourceSetDisplayName = ((DefaultSourceSet)sourceSet).getDisplayName(); - final SableCCSourceSet sableCCSourceSet = new DefaultSableCCSourceSet(sourceSetDisplayName, project.getObjects()); + String sourceSetDisplayName = ((DefaultSourceSet)sourceSet).getDisplayName(); + SableCCSourceSet sableCCSourceSet = new DefaultSableCCSourceSet(sourceSetDisplayName, project.getObjects()); sourceSet.getExtensions().add(SableCCSourceSet.class, SableCCSourceSet.NAME, sableCCSourceSet); sableCCSourceSet.getSableCC().srcDir("src/" + sourceSet.getName() + "/sablecc"); sourceSet.getAllSource().source(sableCCSourceSet.getSableCC()); // Create the output directories for the generated Java source and resources. - final Directory baseOutputDirectory = project.getLayout().getBuildDirectory().get().dir("generated-src/sablecc/" + sourceSet.getName()); - final Directory outputJavaDirectory = baseOutputDirectory.dir("java"); + Directory baseOutputDirectory = project.getLayout().getBuildDirectory().get().dir("generated-src/sablecc/" + sourceSet.getName()); + Directory outputJavaDirectory = baseOutputDirectory.dir("java"); sourceSet.getJava().srcDir(outputJavaDirectory); - final Directory outputResourcesDirectory = baseOutputDirectory.dir("resources"); + Directory outputResourcesDirectory = baseOutputDirectory.dir("resources"); sourceSet.getResources().srcDir(outputResourcesDirectory); // Create the generateSableCCSource task. - final String sableCCTaskName = sourceSet.getTaskName(SABLECC_TASK_VERB, SABLECC_TASK_TARGET); + String sableCCTaskName = sourceSet.getTaskName(SABLECC_TASK_VERB, SABLECC_TASK_TARGET); project.getTasks().register(sableCCTaskName, SableCCTask.class, task -> { task.setDescription("Compiles the " + sourceSetDisplayName + " SableCC grammars."); task.setSource(sableCCSourceSet.getSableCC()); diff --git a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCSourceSet.java b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCSourceSet.java index 1932c05..98ac390 100644 --- a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCSourceSet.java +++ b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCSourceSet.java @@ -9,5 +9,5 @@ public interface SableCCSourceSet { String NAME = "sablecc"; SourceDirectorySet getSableCC(); - SableCCSourceSet sableCC(final Action<? super SourceDirectorySet> configureAction); + SableCCSourceSet sableCC(Action<? super SourceDirectorySet> configureAction); } diff --git a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCTask.java b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCTask.java index 09f84e6..68bdad5 100644 --- a/src/main/java/de/hhu/stups/sablecc/gradle/SableCCTask.java +++ b/src/main/java/de/hhu/stups/sablecc/gradle/SableCCTask.java @@ -70,7 +70,7 @@ public abstract class SableCCTask extends SourceTask { return this.sableCCClasspath; } - public void setSableCCClasspath(final FileCollection sableCCClasspath) { + public void setSableCCClasspath(FileCollection sableCCClasspath) { this.sableCCClasspath = sableCCClasspath; } @@ -80,7 +80,7 @@ public abstract class SableCCTask extends SourceTask { return this.maxHeapSize; } - public void setMaxHeapSize(final String maxHeapSize) { + public void setMaxHeapSize(String maxHeapSize) { this.maxHeapSize = maxHeapSize; } @@ -89,7 +89,7 @@ public abstract class SableCCTask extends SourceTask { return this.destinationJavaDir.get(); } - public void setDestinationJavaDir(final Directory destinationJavaDir) { + public void setDestinationJavaDir(Directory destinationJavaDir) { this.destinationJavaDir.set(destinationJavaDir); } @@ -98,7 +98,7 @@ public abstract class SableCCTask extends SourceTask { return this.destinationResourcesDir.get(); } - public void setDestinationResourcesDir(final Directory destinationResourcesDir) { + public void setDestinationResourcesDir(Directory destinationResourcesDir) { this.destinationResourcesDir.set(destinationResourcesDir); } @@ -117,10 +117,10 @@ public abstract class SableCCTask extends SourceTask { spec.setClasspath(this.getSableCCClasspath()); spec.setMaxHeapSize(this.getMaxHeapSize()); spec.getMainClass().set("org.sablecc.sablecc.SableCC"); - final List<String> args = new ArrayList<>(); + List<String> args = new ArrayList<>(); args.add("-d"); args.add(destinationJavaPath.toString()); - for (final File file : this.getSource().getFiles()) { + for (File file : this.getSource().getFiles()) { args.add(file.getPath()); } spec.setArgs(args); -- GitLab