From 86094dd3ce978287dedaade29eab7629dab4763c Mon Sep 17 00:00:00 2001
From: dgelessus <dgelessus@users.noreply.github.com>
Date: Thu, 20 Jul 2023 17:59:35 +0200
Subject: [PATCH] Simplify list empty check in Parser.checkResult
---
src/main/java/org/sablecc/sablecc/parser/Parser.java | 6 ++----
src/main/resources/org/sablecc/sablecc/parser.txt | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/sablecc/sablecc/parser/Parser.java b/src/main/java/org/sablecc/sablecc/parser/Parser.java
index 82bfea2..c23684d 100644
--- a/src/main/java/org/sablecc/sablecc/parser/Parser.java
+++ b/src/main/java/org/sablecc/sablecc/parser/Parser.java
@@ -50,13 +50,11 @@ public class Parser implements IParser
* added to it
*/
final List<?> nodeList = (List<?>) elementToCheck;
-
- if (nodeList.size() > 0) {
- elementToCheck = nodeList.get(nodeList.size() - 1);
- } else {
+ if (nodeList.isEmpty()) {
// no positions for empty lists...
return;
}
+ elementToCheck = nodeList.get(nodeList.size() - 1);
}
final PositionedNode node = (PositionedNode) elementToCheck;
diff --git a/src/main/resources/org/sablecc/sablecc/parser.txt b/src/main/resources/org/sablecc/sablecc/parser.txt
index 21a877d..e5a46dc 100644
--- a/src/main/resources/org/sablecc/sablecc/parser.txt
+++ b/src/main/resources/org/sablecc/sablecc/parser.txt
@@ -58,13 +58,11 @@ public class Parser implements IParser
* added to it
*/
final List<?> nodeList = (List<?>) elementToCheck;
-
- if (nodeList.size() > 0) {
- elementToCheck = nodeList.get(nodeList.size() - 1);
- } else {
+ if (nodeList.isEmpty()) {
// no positions for empty lists...
return;
}
+ elementToCheck = nodeList.get(nodeList.size() - 1);
}
final PositionedNode node = (PositionedNode) elementToCheck;
--
GitLab