From b34f0ffcb27eda414f6a4b9b82d10f850b14a003 Mon Sep 17 00:00:00 2001
From: Michael Leuschel <leuschel@cs.uni-duesseldorf.de>
Date: Tue, 24 Sep 2019 11:04:59 +0200
Subject: [PATCH] fix bounds of for loop for parameters
---
.../prob/ui/operationview/CustomPreconditionDialogHandler.java | 1 +
.../de/prob/ui/operationview/CustomPreconditionInputDialog.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionDialogHandler.java b/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionDialogHandler.java
index c609f399..4a1fe38a 100644
--- a/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionDialogHandler.java
+++ b/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionDialogHandler.java
@@ -41,6 +41,7 @@ public class CustomPreconditionDialogHandler extends AbstractHandler implements
try {
ExecuteOperationCommand
.executeOperation(Animator.getAnimator(), op);
+ // TODO: provide feedback when we cannot execute operation
} catch (ProBException e) {
e.notifyUserOnce();
}
diff --git a/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionInputDialog.java b/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionInputDialog.java
index eeb0d228..4e40f8bc 100644
--- a/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionInputDialog.java
+++ b/de.prob.ui/src/de/prob/ui/operationview/CustomPreconditionInputDialog.java
@@ -56,7 +56,7 @@ public class CustomPreconditionInputDialog extends InputDialog {
List<String> params = getOperationParams(op,animator);
List<String> vals = op.getArguments();
int sze = Math.min(params.size(),vals.size());
- for (int i = 0; i < sze - 1; i++) {
+ for (int i = 0; i < sze; i++) {
sb.append(params.get(i));
sb.append(" = ");
sb.append(vals.get(i));
--
GitLab