From d083be856bd56338a5e349ffb8e1a0d44e47a20a Mon Sep 17 00:00:00 2001
From: dgelessus <dgelessus@users.noreply.github.com>
Date: Tue, 16 Jun 2020 20:04:39 +0200
Subject: [PATCH] Remove ProBKernel.completeInternal special case for only
whitespace
This code was effectively never called - in Jupyter Notebook, pressing
Tab on a whitespace-only line will add an indent level rather than
triggering code completion.
---
src/main/java/de/prob2/jupyter/ProBKernel.java | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/src/main/java/de/prob2/jupyter/ProBKernel.java b/src/main/java/de/prob2/jupyter/ProBKernel.java
index 68a8456..eba62ad 100644
--- a/src/main/java/de/prob2/jupyter/ProBKernel.java
+++ b/src/main/java/de/prob2/jupyter/ProBKernel.java
@@ -94,7 +94,6 @@ public final class ProBKernel extends BaseKernel {
private static final @NotNull Pattern COMMAND_PATTERN = Pattern.compile("\\s*(\\:[^\\s]*)(?:\\h*(.*))?", Pattern.DOTALL);
private static final @NotNull Pattern MACHINE_CODE_PATTERN = Pattern.compile("MACHINE\\W.*", Pattern.DOTALL);
- private static final @NotNull Pattern SPACE_PATTERN = Pattern.compile("\\s*");
private static final @NotNull Pattern BSYMB_COMMAND_PATTERN = Pattern.compile("\\\\([a-z]+)");
private static final @NotNull Pattern LATEX_FORMULA_PATTERN = Pattern.compile("(\\$\\$?)([^\\$]+)\\1");
@@ -476,15 +475,6 @@ public final class ProBKernel extends BaseKernel {
return null;
}
}
- } else if (SPACE_PATTERN.matcher(code.getValue()).matches()) {
- // The code contains only whitespace, provide completions from :eval and for command names.
- final List<String> replacementStrings = new ArrayList<>();
- final ReplacementOptions evalReplacements = completeCommandArguments(this.getCommands().get(":eval"), code, at);
- if (evalReplacements != null) {
- replacementStrings.addAll(evalReplacements.getReplacements());
- }
- replacementStrings.addAll(this.getCommands().keySet().stream().sorted().collect(Collectors.toList()));
- return new ReplacementOptions(replacementStrings, at, at);
} else {
// The code is not a valid command, ask :eval for completions.
return completeCommandArguments(this.getCommands().get(":eval"), code, at);
--
GitLab