diff --git a/DESCRIPTION b/DESCRIPTION index a1ac9ad039c389ea24f153058a04e9681f581776..bc7a4d2cf6e6ef3da728e4f944db641d2809569d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: sybil Type: Package Title: Efficient Constrained Based Modelling in R -Version: 2.0.2 -Date: 2017-03-24 +Version: 2.0.3 +Date: 2017-04-20 Authors@R: c( person(c("C.", "Jonathan"), "Fritzemeier", role = c("cre", "ctb"), email = "clausjonathan.fritzemeier@uni-duesseldorf.de"), person("Gabriel", "Gelius-Dietrich", role = c("aut")), @@ -53,7 +53,7 @@ Collate: generics.R validmodelorg.R validoptsol.R validreactId.R sysBiolAlg_lmomaClass.R sysBiolAlg_momaClass.R sysBiolAlg_mtfClass.R sysBiolAlg_mtfEasyConstraintClass.R sysBiolAlg_roomClass.R sybilLogClass.R upgradeModelorg.R -Packaged: 2017-03-24 12:34:14 UTC; jonathan +Packaged: 2017-04-20 12:34:14 UTC; jonathan Author: C. Jonathan Fritzemeier [cre, ctb], Gabriel Gelius-Dietrich [aut], Rajen Piernikarczyk [ctb], diff --git a/R/generateWT.R b/R/generateWT.R index 52811193a2e350977bf663f2863b411183958e2c..b63f54e62ba9242cdeac585d1fc5b4eb4a72ed87 100644 --- a/R/generateWT.R +++ b/R/generateWT.R @@ -52,30 +52,30 @@ # setting ... parameters into list ca <- list(...) - if(is.null(ca$solver)){ - ca$solver <- SYBIL_SETTINGS("SOLVER") + if(is.null(ca[["solver"]])){ + ca[["solver"]] <- SYBIL_SETTINGS("SOLVER") } - me <- checkDefaultMethod(solver = ca$solver, + me <- checkDefaultMethod(solver = ca[["solver"]], method = "NA", probType = "lp", loadPackage = FALSE) - ca$solver <- me[["sol"]] - ca$method <- me[["met"]] - ca$solverParm <- as.data.frame(NA) + ca[["solver"]] <- me[["sol"]] + ca[["method"]] <- me[["met"]] + ca[["solverParm"]] <- as.data.frame(NA) - ca$object <- model - if(is.null(ca$algorithm)) ca$algorithm <- "fba" - ca$react <- react - ca$ub <- ub - ca$lb <- lb + ca[["object"]] <- model + if(is.null(ca[["algorithm"]])) ca[["algorithm"]] <- "fba" + ca[["react"]] <- react + ca[["ub"]] <- ub + ca[["lb"]] <- lb if (is(react, "list")) { message("calculating fba solutions ... ", appendLF = FALSE) suppressMessages({ - ca$lpdir <- rep("max", length(react)) - ca$verboseMode <- 0 + ca[["lpdir"]] <- rep("max", length(react)) + ca[["verboseMode"]] <- 0 tmp <- do.call(optimizer, ca) # tmp <- optimizer(model, algorithm = algorithm, @@ -87,8 +87,8 @@ message("OK") } else { - ca$retOptSol <- FALSE - ca$lpdir <- "max" + ca[["retOptSol"]] <- FALSE + ca[["lpdir"]] <- "max" tmp <- do.call("optimizeProb", ca) # tmp <- optimizeProb(model, # react = react, lb = lb, ub = ub, diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd index c98743f7fe06f20f38260be68f8767139b7f5ac9..620fda7b99bb7570c3023c66807944a182c6c2e9 100644 --- a/inst/NEWS.Rd +++ b/inst/NEWS.Rd @@ -6,6 +6,13 @@ \newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}} +\section{Changes in version 2.0.3 2017-04-20}{ + \itemize{ + \item The function \code{genrateWT} caused a problem when setting only \code{solverParm} and no solver. + } +} +% ---------------------------------------------------------------------------- % + \section{Changes in version 2.0.2 2017-03-24}{ \itemize{ \item The function \code{mod2irrev} crashed when using models with just one gene.