From 90a325784b360d4318a31931979d1987a273518c Mon Sep 17 00:00:00 2001
From: Claus Jonathan Fritzemeier <clausjonathan.fritzemeier@hhu.de>
Date: Tue, 29 Sep 2015 14:47:43 +0200
Subject: [PATCH] corrected mistake in deadEndMetabolite (thuong)
---
R/deadEndMetabolite.R | 2 +-
inst/NEWS.Rd | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/R/deadEndMetabolite.R b/R/deadEndMetabolite.R
index f74c8c5..b5fe7b1 100644
--- a/R/deadEndMetabolite.R
+++ b/R/deadEndMetabolite.R
@@ -95,7 +95,7 @@
# dead end list: test all reactions k > j
k <- j+1
while (k <= length(nz)) {
- if ( (tmp_mat[i, nz[k]] != tmp_mat[i, nz[j]]) ||
+ if ( ( sign(tmp_mat[i, nz[k]]) != sign(tmp_mat[i, nz[j]]) ) ||
(lb[nz[k]] < 0) ||
(lb[nz[j]] < 0) ) {
#print(paste(i,":",k))
diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd
index 414e4ca..0b5d4ac 100644
--- a/inst/NEWS.Rd
+++ b/inst/NEWS.Rd
@@ -6,6 +6,12 @@
\newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}}
+\section{Changes in version 1.3.1 2015-08-06}{
+ \itemize{
+ \item \code{deadEndMetabolite()} could miss deadEndMetabolites if reactions differ in stoichiometry e.g. 1 and 2.
+ }
+}
+
\section{Changes in version 1.3.1 2015-08-06}{
\itemize{
\item \code{readTSVmod} had a mistake in the documentation about singletons.
--
GitLab