From 8366cbe78dec8ac3189b65dcbf4d595e358c24a8 Mon Sep 17 00:00:00 2001
From: Claus Jonathan Fritzemeier <clausjonathan.fritzemeier@hhu.de>
Date: Wed, 12 Jul 2017 16:30:46 +0200
Subject: [PATCH] rmReact react_attr bug
---
DESCRIPTION | 4 ++--
R/rmReact.R | 4 ++--
inst/NEWS.Rd | 3 ++-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/DESCRIPTION b/DESCRIPTION
index bc7a4d2..f62fff4 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: sybil
Type: Package
Title: Efficient Constrained Based Modelling in R
Version: 2.0.3
-Date: 2017-04-20
+Date: 2017-07-12
Authors@R: c(
person(c("C.", "Jonathan"), "Fritzemeier", role = c("cre", "ctb"), email = "clausjonathan.fritzemeier@uni-duesseldorf.de"),
person("Gabriel", "Gelius-Dietrich", role = c("aut")),
@@ -53,7 +53,7 @@ Collate: generics.R validmodelorg.R validoptsol.R validreactId.R
sysBiolAlg_lmomaClass.R sysBiolAlg_momaClass.R
sysBiolAlg_mtfClass.R sysBiolAlg_mtfEasyConstraintClass.R
sysBiolAlg_roomClass.R sybilLogClass.R upgradeModelorg.R
-Packaged: 2017-04-20 12:34:14 UTC; jonathan
+Packaged: 2017-07-12 12:34:14 UTC; jonathan
Author: C. Jonathan Fritzemeier [cre, ctb],
Gabriel Gelius-Dietrich [aut],
Rajen Piernikarczyk [ctb],
diff --git a/R/rmReact.R b/R/rmReact.R
index c420d70..d506236 100644
--- a/R/rmReact.R
+++ b/R/rmReact.R
@@ -135,7 +135,7 @@ rmReact <- function(model, react, rm_met = TRUE) {
react_de(mod_out) <- react_de(model)[keepReact]
if(ncol(react_attr(model))>0){
- react_attr(mod_out) <- react_attr(model)[keepReact, ]
+ react_attr(mod_out) <- react_attr(model)[keepReact, , drop=F]
}
react_num(mod_out) <- length(react_id(mod_out))
@@ -204,7 +204,7 @@ rmReact <- function(model, react, rm_met = TRUE) {
met_de(mod_out) <- met_de(model)[keepMet]
if(ncol(met_attr(model))>0){
- met_attr(mod_out) <- met_attr(model)[keepMet, ]
+ met_attr(mod_out) <- met_attr(model)[keepMet, , drop=F]
}
}
else {
diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd
index 620fda7..ad994a1 100644
--- a/inst/NEWS.Rd
+++ b/inst/NEWS.Rd
@@ -6,9 +6,10 @@
\newcommand{\CRANpkg}{\href{http://CRAN.R-project.org/package=#1}{\pkg{#1}}}
-\section{Changes in version 2.0.3 2017-04-20}{
+\section{Changes in version 2.0.3 2017-07-12}{
\itemize{
\item The function \code{genrateWT} caused a problem when setting only \code{solverParm} and no solver.
+ \item \code{rmReact} handles now \code{react_attr} and \code{met_attr} corretly, if there is just one column.
}
}
% ---------------------------------------------------------------------------- %
--
GitLab